chore: librarian generate pull request: 20260210T151820Z #15553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the GKE Hub API by introducing a new set of resources and associated operations. The changes enable more granular management of GKE Fleets, including the ability to define and control Scopes, Namespaces, Membership Bindings, and RBAC Role Bindings. This expansion provides users with greater flexibility and control over their GKE environments through programmatic interfaces. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request primarily updates the google-cloud-gke-hub library by regenerating its client code, as indicated by the last_generated_commit change in .librarian/state.yaml. The core changes involve introducing extensive new functionality related to GKE Hub's Fleet, Scope, Namespace, MembershipBinding, and RBACRoleBinding resources. This includes adding new type definitions for these resources and their lifecycle states in google/cloud/gkehub_v1/types/fleet.py, and updating google/cloud/gkehub/__init__.py and google/cloud/gkehub_v1/__init__.py to import and expose these new types and their associated service request/response messages. The gapic_metadata.json file is updated to reflect the new GAPIC client methods for creating, getting, updating, deleting, and listing these resources, as well as generating RBAC YAML. Correspondingly, new pager classes are added in pagers.py for paginated list operations, and the base.py, grpc.py, and grpc_asyncio.py transport implementations are extended to support the new methods. Additionally, rest_base.py gains new classes for REST API transcoding of these operations. The feature.py file is updated to include ScopeFeatureSpec and ScopeFeatureState, and to change terminology from 'Hub' to 'Fleet' in comments, along with adding rbacrolebindingactuation to CommonFeatureState and new fields for scope_specs, scope_states, and unreachable to the Feature message. The review comment suggests alphabetically sorting the symbols in the __all__ list for better maintainability and readability.
Comment on lines
32
to
40
| "FeatureState", | ||
| "CommonFeatureSpec", | ||
| "CommonFeatureState", | ||
| "ScopeFeatureSpec", | ||
| "ScopeFeatureState", | ||
| "MembershipFeatureSpec", | ||
| "MembershipFeatureState", | ||
| }, | ||
| ) |
Contributor
There was a problem hiding this comment.
For better maintainability and readability, the symbols in __all__ should be sorted alphabetically.
"CommonFeatureSpec",
"CommonFeatureState",
"Feature",
"FeatureResourceState",
"FeatureState",
"MembershipFeatureSpec",
"MembershipFeatureState",
"ScopeFeatureSpec",
"ScopeFeatureState",
ohmayr
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
request_idin message.google.cloud.gkehub.v1.CreateFeatureRequestis changedPiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
cancel_requestedin message.google.cloud.gkehub.v1.OperationMetadatais changedPiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add GKE Hub teams scope and RBAC GAPIC
PiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for message
Featureis changedPiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
statein message.google.cloud.gkehub.v1.Featureis changedPiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for enum value
ACTIVEin enumStateis changedPiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for enum value
DISABLINGin enumStateis changedPiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
labelsin message.google.cloud.gkehub.v1.Featureis changedPiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
statein message.google.cloud.gkehub.v1.CommonFeatureStateis changedPiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for enum value
ENABLINGin enumStateis changedPiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for message
CommonFeatureStateis changedPiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
request_idin message.google.cloud.gkehub.v1.UpdateFeatureRequestis changedPiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
specin message.google.cloud.gkehub.v1.Featureis changedPiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
membership_specsin message.google.cloud.gkehub.v1.Featureis changedPiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
membership_statesin message.google.cloud.gkehub.v1.Featureis changedPiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for message
FeatureResourceStateis changedPiperOrigin-RevId: 865111649
Library-IDs: google-cloud-gke-hub
Source-link: googleapis/googleapis@7a570661
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@33225118
(exclusive) and
googleapis/googleapis@7a570661
(inclusive).
Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:f5426423676c75008c2135037e7b98f78cbb99f78b3c46fe043b6897be92d836
Fixes #15525